fix: graph deprecation snapshots with normalization #5524

khendrikse · 2023-03-02T12:43:48Z

🎉 Thanks for submitting a pull request! 🎉

Summary

Trying to somehow make all the snapshot tests work.

A picture of a cute animal (not mandatory, but encouraged)

github-actions · 2023-03-02T12:45:38Z

📊 Benchmark results

Comparing with f667d27

Package size: 263 MB

⬆️ 0.00% increase vs. f667d27

^  263 MB  263 MB  263 MB  263 MB  262 MB  262 MB  262 MB  263 MB  263 MB  263 MB  263 MB  263 MB  263 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (7998a74): 270 MB
T-29 (34e92bd): 263 MB
T-28 (3412ff2): 263 MB
T-27 (50fbfb4): 263 MB
T-26 (171a14a): 263 MB
T-25 (edad634): 263 MB
T-24 (0ee25ee): 263 MB
T-23 (4f51213): 263 MB
T-22 (028b1ba): 263 MB
T-21 (57e8d8a): 263 MB
T-20 (985208a): 263 MB
T-19 (48ec641): 263 MB
T-18 (c638edb): 263 MB
T-17 (6567606): 263 MB
T-16 (cb4479f): 263 MB
T-15 (748bc5c): 263 MB
T-14 (0c3fd0a): 263 MB
T-13 (046e6b9): 263 MB
T-12 (2b80cdc): 263 MB
T-11 (97465e8): 263 MB
T-10 (4b6d387): 263 MB
T-9 (5fb20ff): 263 MB
T-8 (881dff6): 262 MB
T-7 (ab792a9): 262 MB
T-6 (8fd947a): 262 MB
T-5 (a78f641): 263 MB
T-4 (b94711b): 263 MB
T-3 (536db4e): 263 MB
T-2 (bbb80e9): 263 MB
T-1 (f667d27): 263 MB
T (current commit): 263 MB

ascorbic · 2023-03-02T13:28:41Z

tests/integration/utils/snapshots.cjs

@@ -8,6 +8,7 @@ const baseNormalizers = [
  { pattern: /\\/gu, value: '/' },
  { pattern: /\r\n/gu, value: '\n' },
  { pattern: /❯/gu, value: '>' },
+  { pattern: /»/gu, value: '›' },


Every one of these lines is a story of somebody's pain

khendrikse added 2 commits March 2, 2023 13:42

fix: add specific windows character to snapshot normalizer

623256a

fix: add specific windows character to snapshot normalizer

a09730f

khendrikse self-assigned this Mar 2, 2023

khendrikse added the type: chore work needed to keep the product and development running smoothly label Mar 2, 2023

fix: add specific windows character to snapshot normalizer

aec4441

ascorbic reviewed Mar 2, 2023

View reviewed changes

ascorbic approved these changes Mar 2, 2023

View reviewed changes

khendrikse added the automerge Add to Kodiak auto merge queue label Mar 2, 2023

kodiakhq bot merged commit 48e94f7 into main Mar 2, 2023

kodiakhq bot deleted the fix/fix-graph-deprecation-snapshots-with-normalization branch March 2, 2023 13:35

token-generator-app bot mentioned this pull request Mar 2, 2023

chore(main): release 13.0.1 #5501

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: graph deprecation snapshots with normalization #5524

fix: graph deprecation snapshots with normalization #5524

khendrikse commented Mar 2, 2023 •

edited

github-actions bot commented Mar 2, 2023 •

edited

ascorbic Mar 2, 2023

fix: graph deprecation snapshots with normalization #5524

fix: graph deprecation snapshots with normalization #5524

Conversation

khendrikse commented Mar 2, 2023 • edited

Summary

github-actions bot commented Mar 2, 2023 • edited

📊 Benchmark results

Package size: 263 MB

ascorbic Mar 2, 2023

Choose a reason for hiding this comment

khendrikse commented Mar 2, 2023 •

edited

github-actions bot commented Mar 2, 2023 •

edited