fix: support multiple path values in edge functions config #5480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Feb 16, 2023
|
|
||
| if (index === -1) { | ||
| declarations.push(declarationFromSource) | ||
| const { path: pathOrPaths, ...configProps } = declarationFromSource |
There was a problem hiding this comment.
Not a fan of this. I think Edge Bundler should be the one merging the two config sources, since where most of that existing logic lives.
📊 Benchmark resultsComparing with 5011be5 Package size: 263 MB(no change) Legend
|
khendrikse
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where an error is thrown for edge functions defining a
pathproperty with multiple values via in-source configuration.