-
Notifications
You must be signed in to change notification settings - Fork 400
feat: show displayName for any function that has one being run with ntl dev #5444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
khendrikse
merged 4 commits into
main
from
feat-373/show-display-name-for-functions-when-running-ntl-dev
Feb 1, 2023
Merged
feat: show displayName for any function that has one being run with ntl dev #5444
khendrikse
merged 4 commits into
main
from
feat-373/show-display-name-for-functions-when-running-ntl-dev
Feb 1, 2023
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with cd9ebf8 Package size: 265 MB⬇️ 0.00% decrease vs. cd9ebf8
Legend
|
…n-running-ntl-dev
eduardoboucas
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Add to Kodiak auto merge queue
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Work for https://github.com/netlify/pod-compute/issues/373 to show a display name if available for functions.
Is dependent on netlify/zip-it-and-ship-it#1329
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)