feat: rename x-deno- to x-nf-

[Skn0tt]

Part of https://github.com/netlify/partner-deno/issues/11. Renames the x-deno- headers to x-nf-. Will fail right now, but work once netlify/edge-bundler#290 lands.

[github-actions]

📊 Benchmark results

Comparing with 6726bf4

Package size: 267 MB

⬇️ 0.00% decrease vs. 6726bf4

^                  267 MB  267 MB 
│  260 MB  260 MB   ┌──┐    ┌──┐  
│   ┌──┐    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴──>
    T-3     T-2     T-1      T    

Legend

• T-3 (bce1f2c): 260 MB
• T-2 (2d3923c): 260 MB
• T-1 (6726bf4): 267 MB
• T (current commit): 267 MB

[Skn0tt]

ab1da2c should've failed some tests 🤔 why is it not?

[Skn0tt]

why is it not?

it should've failed tests in https://github.com/netlify/cli/blob/main/tests/integration/100.command.dev.test.cjs, but these tests were never executed. It looks like that's because we use Vitest's --changed option, which only executes tests that are dependent on the changed file. That dependency is detected by tracing imports, but since integration tests don't import the source code but run the CLI via execa instead, it can't detect how these fit together.

Here's the imports for the test file that should've been run, but wasn't:

cli/tests/integration/100.command.dev.test.cjs

Lines 1 to 20 in 2527070

	// Handlers are meant to be async outside tests
	const path = require('path')
	// eslint-disable-next-line ava/use-test
	const avaTest = require('ava')
	const { isCI } = require('ci-info')
	const dotProp = require('dot-prop')
	const jwt = require('jsonwebtoken')
	const { Response } = require('node-fetch')
	const { withDevServer } = require('./utils/dev-server.cjs')
	const got = require('./utils/got.cjs')
	const { withMockApi } = require('./utils/mock-api.cjs')
	const { pause } = require('./utils/pause.cjs')
	const { withSiteBuilder } = require('./utils/site-builder.cjs')
	const test = isCI ? avaTest.serial.bind(avaTest) : avaTest
	const JWT_EXPIRY = 1_893_456_000
	const getToken = ({ jwtRolePath = 'app_metadata.authorization.roles', jwtSecret = 'secret', roles }) => {

As you can see, there's no import of the source files in there, so Vitest's --change dependency tracing doesn't pick it up.

I'll open a separate issue to track this bug in our CI. Let's go ahead with this PR.