Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: publish shrinkwrap with prod dependencies only (#5359)" #5364

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

danez
Copy link
Contributor

@danez danez commented Jan 11, 2023

This reverts commit 65f77d9.

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

The shrinkwrap change does not work, because npm generates an invalid package-lock/shrinkwrap on publish.

So the cli version 12.7.1 cannot be installed at all


➜ npm install -g netlify-cli
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated statsd-client@0.4.7: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! code 1
npm ERR! path /Users/danieltschinder/.asdf/installs/nodejs/18.12.1/lib/node_modules/netlify-cli/node_modules/@netlify/esbuild
npm ERR! command failed
npm ERR! command sh -c -- node install.js
npm ERR! [esbuild] Failed to find package "@netlify/esbuild-darwin-arm64" on the file system
npm ERR! 
npm ERR! This can happen if you use the "--no-optional" flag. The "optionalDependencies"
npm ERR! package.json feature is used by esbuild to install the correct binary executable
npm ERR! for your current platform. This install script will now attempt to work around
npm ERR! this. If that fails, you need to remove the "--no-optional" flag to use esbuild.
npm ERR! 
npm ERR! node:internal/modules/cjs/loader:995
npm ERR!   const err = new Error(message);
npm ERR!               ^
npm ERR! 
npm ERR! Error: Cannot find module 'esbuild'
npm ERR! Require stack:
npm ERR! - /Users/danieltschinder/.asdf/installs/nodejs/18.12.1/lib/node_modules/netlify-cli/node_modules/@netlify/esbuild/install.js
npm ERR!     at Module._resolveFilename (node:internal/modules/cjs/loader:995:15)
npm ERR!     at Function.resolve (node:internal/modules/cjs/helpers:109:19)
npm ERR!     at downloadedBinPath (/Users/danieltschinder/.asdf/installs/nodejs/18.12.1/lib/node_modules/netlify-cli/node_modules/@netlify/esbuild/install.js:86:46)
npm ERR!     at checkAndPreparePackage (/Users/danieltschinder/.asdf/installs/nodejs/18.12.1/lib/node_modules/netlify-cli/node_modules/@netlify/esbuild/install.js:232:15)
npm ERR!     at Object.<anonymous> (/Users/danieltschinder/.asdf/installs/nodejs/18.12.1/lib/node_modules/netlify-cli/node_modules/@netlify/esbuild/install.js:247:1)
npm ERR!     at Module._compile (node:internal/modules/cjs/loader:1159:14)
npm ERR!     at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
npm ERR!     at Module.load (node:internal/modules/cjs/loader:1037:32)
npm ERR!     at Module._load (node:internal/modules/cjs/loader:878:12)
npm ERR!     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
npm ERR!   code: 'MODULE_NOT_FOUND',
npm ERR!   requireStack: [
npm ERR!     '/Users/danieltschinder/.asdf/installs/nodejs/18.12.1/lib/node_modules/netlify-cli/node_modules/@netlify/esbuild/install.js'
npm ERR!   ]
npm ERR! }
npm ERR! 
npm ERR! Node.js v18.12.1

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/danieltschinder/.npm/_logs/2023-01-11T16_15_13_392Z-debug-0.log

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@danez danez self-assigned this Jan 11, 2023
@danez danez added automerge Add to Kodiak auto merge queue and removed automerge Add to Kodiak auto merge queue labels Jan 11, 2023
@danez danez enabled auto-merge (squash) January 11, 2023 16:40
@danez danez merged commit 9d96313 into main Jan 11, 2023
@danez danez deleted the revert branch January 11, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants