feat: add serve command
#5351
Merged
feat: add serve command
#5351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matt Kane <m@mk.gg>
eduardoboucas
added
the
type: feature
ascorbic
reviewed
Jan 6, 2023
ascorbic
reviewed
Jan 6, 2023
📊 Benchmark resultsComparing with 2b7045e Package size: 259 MB(no change) Legend
|
eduardoboucas
changed the title
serve commandserve command
eduardoboucas
commented
Jan 9, 2023
| const { success } = await buildSite(buildSiteOptions) | ||
|
|
||
| if (!success) { | ||
| error('Could not start local server due to a build error') |
There was a problem hiding this comment.
@ascorbic This addresses a comment you made earlier.
ascorbic
reviewed
Jan 9, 2023
Co-authored-by: Matt Kane <m@mk.gg>
|
@ascorbic Could you give this another look? |
ascorbic
approved these changes
Jan 10, 2023
|
Hey @eduardoboucas, I was just starting to create the docs issue to add this to the Get Started with the CLI doc once this is no longer in beta and I went to refer to the CLI command reference docs that you link to from the readme, but it doesn't look like those were added ( |
|
Hmm, that's weird. That file should've been created automatically and deployed to the docs site, but for some reason it wasn't. I'll investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds on top of #5338 and moves the
--prodflag into a separateservecommand. I used this opportunity to move a bunch of logic our of the dev command file and into auxiliary files that can be included from multiple commands, so the diff looks much scarier than it actually is.I tried to add some comments about which parts have moved around, and I'm happy to answer any questions about what changed.