-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ef templates): replace context.json with Response.json #5342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Jan 2, 2023
📊 Benchmark resultsComparing with 7eb4479 Package size: 249 MB(no change)
Legend
|
Skn0tt
commented
Jan 2, 2023
@@ -1,5 +1,5 @@ | |||
import type { Context } from "https://edge.netlify.com"; | |||
|
|||
export default async (request: Request, context: Context) => { | |||
return context.json({ hello: "world" }); | |||
return Response.json({ hello: "world", location: context.geo.city }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the location
field here to be in line with #5340 (comment).
eduardoboucas
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Add to Kodiak auto merge queue
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.com/netlify/edge-functions-bootstrap/pull/142#issuecomment-1368897194, let's change the ef template code to use
Response.json
instead of the soon-to-be-deprecatedcontext.json
.