-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use console.log for logging in ef template #5340
Conversation
@@ -1,9 +1,9 @@ | |||
import type { Context } from "https://edge.netlify.com"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave the type import here. context
is unused in the template itself, but it's good to have around - this is a template, and devs will either use context
(and be happy to have the types!) or remove it themselves :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Another option would be to change the response to include something from context
, so that the variable is actually used. Something like context.ip
or context.geo.city
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea, a good way for product discovery! Implemented in 30d8ffc. I chose context.geo.city
, geolocation is probably more of an interesting feature than the IP address :D
📊 Benchmark resultsComparing with e3db314 Package size: 249 MB⬇️ 0.00% decrease vs. e3db314
Legend
|
part of https://github.com/netlify/pod-compute/issues/316