fix: always look for internal edge functions #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Dec 9, 2022
| @@ -71,7 +71,7 @@ const getInternalFunctions = async () => { | |||
| } catch { | |||
| return { | |||
| functions: [], | |||
| path: null, | |||
There was a problem hiding this comment.
This was the actual problem.
📊 Benchmark resultsComparing with 869c5a8 Package size: 254 MB⬇️ 0.00% decrease vs. 869c5a8 |
danez
approved these changes
Dec 9, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when CLI doesn't find a valid
manifest.jsonfile in the internal edge functions directory, it doesn't even look for edge functions in that directory. This means that declaring an internal edge function using in-source configuration without an accompanying manifest file doesn't work.This PR addresses that by ensuring we always look for functions in that directory, regardless of whether or not there's a manifest with declarations.