chore: migrate more to ESM #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with e65f97c Package size: 254 MB(no change) Legend
|
danez
force-pushed
the
esm4
branch
2 times, most recently
from
0ae4a17
to
220bd13
Compare
danez
commented
Dec 7, 2022
| @@ -357,7 +357,6 @@ | |||
| "serialize-javascript": "^6.0.0", | |||
| "sinon": "^14.0.0", | |||
| "strip-ansi": "^6.0.0", | |||
| "supertest": "^6.1.6", | |||
There was a problem hiding this comment.
was only used in one test, instead I now used simply got to do the query.
danez
commented
Dec 7, 2022
| }) | ||
|
|
||
| t.is(ntlFunction.url, functionUrl) | ||
| }) |
danez
commented
Dec 12, 2022
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Removed retry logic as it was only introduced to fix tests. If this is still a problem, we need to mock this file.
We probably should mock this anyway, as tests should not write global config file.
danez
commented
Dec 12, 2022
| } | ||
|
|
||
| // Memoise config result so that we only load it once | ||
| module.exports = memoizeOne(getGlobalConfig) |
There was a problem hiding this comment.
memoizeOne removed as it was completely unneccessary. We never call getGlobalConfig() with any arguments so it would anyway only cache it once.
danez
commented
Dec 12, 2022
| @@ -305,7 +303,6 @@ | |||
| "netlify-redirector": "^0.3.1", | |||
| "node-fetch": "^2.6.0", | |||
| "node-version-alias": "^1.0.1", | |||
| "omit.js": "^2.0.2", | |||
There was a problem hiding this comment.
Used destructuring instead of omit.js
-x = omit(config.build, ['publish', 'publishOrigin']) }
+// eslint-disable-next-line no-unused-vars
+const { publish, publishOrigin, ...x } = config.build
khendrikse
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting close
I know this is huge, but it will soon be done.