fix: detect requests without body correctly #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with fd7db45 Package size: 247 MB(no change) |
if a request goes through an edge function the content-length header will not be set and instead the transfer-enconding is set to chunked.
src/lib/functions/server.mjs
Outdated
| @@ -41,6 +41,13 @@ const buildClientContext = function (headers) { | |||
| } | |||
| } | |||
|
|
|||
| const hasBody = (req) => | |||
| // copied from is-type package | |||
| (req.header('transfer-encoding') !== undefined || !Number.isNaN(req.header('content-length'))) && | |||
There was a problem hiding this comment.
Why're we specifically checking for the NaN value here?
In the type-is package the global isNaN function is used which behaves differently from the Number.isNaN function since the global isNaN is true for any non-numeric value (strings, undefined, null etc.) while the Number.isNaN is only true for the NaN value & nothing else.
Ref: https://github.com/jshttp/type-is/blob/7d19b7aab1ad671f59ba157ae0640cd4b1302ca5/index.js#L92-L95
There was a problem hiding this comment.
Interesting, I wasn't aware of that and I just changed it because some eslint rule recommended it.
I changed it to the global version
eduardoboucas
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a request goes through an edge function the
content-lengthheader will be removed and instead thetransfer-encondingis set to chunked. Our detection in the functions (non-edge) server was detecting these passthrough requests as requests without body, because of the missingcontent-length.content-lengthshould be ignored anyways whentransfer-encodingis used according to the HTTP/1.1 spec.Fixes #5030
This also changes
request.get(...)andrequest.headers[...]torequest.header(...)for readability.