chore: migrate more codebase to ESM #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 2b5d96c Package size: 247 MB⬇️ 0.00% decrease vs. 2b5d96c Legend
|
github-actions
bot
added
the
type: chore
danez
changed the title
danez
commented
Nov 28, 2022
|
|
||
| // 12 hours | ||
| const UPDATE_CHECK_INTERVAL = 432e5 | ||
| const pkg = JSON.parse(readFileSync(fileURLToPath(new URL('../package.json', import.meta.url))), 'utf-8') | ||
| const pkg = await getPackageJson() |
There was a problem hiding this comment.
This was extracted into a separate file, so we do not have to do this all over again multiple times.
danez
commented
Nov 28, 2022
| import getGlobalConfig from '../utils/get-global-config.cjs' | ||
| import { openBrowser } from '../utils/open-browser.cjs' | ||
| import StateConfig from '../utils/state-config.mjs' | ||
| import { identify, track } from '../utils/telemetry/index.mjs' |
There was a problem hiding this comment.
I started unusing /utils/index.cjs, and instead import utils from individual files :
- It is easier to migrate
- It makes node not require everything at once, which might come in handy once the commands are not all loaded always, and only the command in use.
So the goal would be to remove utils/index.cjs at some point, but if anyone feels opposed to that it can also be reinstated at the end of the migration.
danez
commented
Nov 28, 2022
| ]) | ||
| t.deepEqual(watchDirs, [path.join(builder.directory, 'functions'), path.join(builder.directory, 'utils')]) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
getFunctionsAndWatchDirs was unused, so removed.
danez
commented
Nov 28, 2022
| const functionsWithProps = functions.filter(({ runtime }) => runtime === JS).map((func) => addFunctionProps(func)) | ||
|
|
||
| return { functions: functionsWithProps, watchDirs } | ||
| } |
There was a problem hiding this comment.
getFunctionsAndWatchDirs was unused so removed
danez
commented
Nov 28, 2022
| packageJson = JSON.parse(await readFile(packageJsonPath)) | ||
| } | ||
|
|
||
| return packageJson |
There was a problem hiding this comment.
This now also caches the root package.json of the cli as I do not think it will change during runtime.
khendrikse
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates some parts of the codebase to ESM.
To move further I have to first introduce vitest for the unit tests to be able to properly mock modules, which rewiremock fails with esm now.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)