Display more informative error information in TimeoutError response body #1460
+25
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caesarsol
changed the title
erezrokah
suggested changes
Oct 21, 2020
There was a problem hiding this comment.
Thank you for this @caesarsol, I believe you'll need to run npm run format to fix the linting errors on CI
|
Sorry about that! I'll do whenever I find the time. |
|
Rewrote commit! |
|
Solved conflict and linting problem |
erezrokah
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
@caesarsol sorry for the late follow up on this.
I made some additional fixes:
- When
erris not a lambda error, it is a string, not an error instance - changed the code accordingly. - When the error comes from lambda it was already logged by
winstonso no need toconsole.logit again (it is logged as JSON as the moment but that's another issue). - Extracted the custom validation Netlify CLI does on lambda response to a separate function.
Please let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Closes #1459, problem described with detail in relative issue.
There are more elegant ways to solve this, but I would delay them to later times. This is kind of a quick but solid workaround.
I also removed the colored
◈from the response body (ANSI chars), and changed the console log message to include the same exact failure message of the response: "Function invocation failed" (was slightly different, creating confusion).- Test plan
Tested as described in #1459 with a TimeoutError, and by manually causing a
new Errorin the code.Knowing what else can cause an error would help in triggering other possible error types.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Thanks! ;)