Support custom spec file suffix #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Looks good so far! |
garritfra
commented
Jun 17, 2022
| ? noop() | ||
| : filter((path) => { | ||
| const specNamingConvention = options.specFileSuffix || 'spec'; | ||
| const languageExtension = options.language || 'ts'; |
There was a problem hiding this comment.
I wasn't sure if using a static file extension may result in a bug when using JS. Let me know if this is fine, and I'll revert this.
garritfra
force-pushed
the
feature/custom-spec-suffix
branch
from
d9e80d2
to
3ab21dc
Compare
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
micalevisk
reviewed
Jun 25, 2022
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
micalevisk
approved these changes
Jun 26, 2022
hebertcisco
approved these changes
Jul 7, 2022
|
LGTM |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143.
Groundwork for nestjs/nest-cli#1683.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The file suffix of unit test files is always
.spec.ts.What is the new behavior?
The suffix can now be customized. E.g.:
.spec.ts,.test.ts,.foo.ts.This serves as preparation for the issue linked above.
Does this PR introduce a breaking change?
Other information
I'm opening this PR as a draft and gradually implement this behavior for all the schematics. I'd love to get feedback along the way though!