Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): added alias for interface and rename alias interceptor #1054

Merged
merged 1 commit into from Jul 8, 2022

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented May 29, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Proposal:
Added alias ìtf for interface and renamed alias int in itc for interceptor

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tony133
Copy link
Contributor Author

Tony133 commented Jun 2, 2022

Right!, I created a PR for that in the Nest cli repository as well, thanks for reminding me! 👍 (see here)

@kamilmysliwiec
Copy link
Member

Isn't it an unnecessary breaking change though? That's what worries me the most

@Tony133
Copy link
Contributor Author

Tony133 commented Jun 2, 2022

What prompted me to do this PR is that they are not very intuitive as alias names, for example interceptor is an in, while alias for the interface is not really an alias because it is the name itself. It would be nice to change them and make them more "alias" or real "alias". 😁

Anyway maybe I understand what you mean, that you would like to make them similar enough if you upgrade the nest version to a new one? But since the main version of nest v9 is on the way, there could be this change, no?

@kamilmysliwiec kamilmysliwiec merged commit 68547be into nestjs:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants