Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): expose each option to get and resolve methods #10521

Merged
merged 7 commits into from Nov 7, 2022

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Nov 5, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Nov 5, 2022

Pull Request Test Coverage Report for Build 9df5ad94-c45f-4431-b6d6-42327622d71e

  • 35 of 41 (85.37%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 93.736%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/injector/module.ts 0 1 0.0%
packages/core/injector/abstract-instance-resolver.ts 20 25 80.0%
Totals Coverage Status
Change from base Build 9368760d-44c3-4ebb-9e88-2f8c5508d382: -0.05%
Covered Lines: 6135
Relevant Lines: 6545

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec marked this pull request as ready for review November 7, 2022 09:16
@kamilmysliwiec kamilmysliwiec merged commit 8039161 into master Nov 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat/add-each-to-resolve-and-get branch November 7, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants