Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): change repl() function param type to Type | DynamicModule #10497

Merged
merged 1 commit into from Nov 7, 2022

Conversation

CodyTseng
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #10494

What is the new behavior?

repl() function can accept DynamicModule type parameter.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8de21cb7-bd15-4791-aa10-a3f39d112a39

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.788%

Totals Coverage Status
Change from base Build 429b8255-55d8-42a4-b8d8-82bc75f526f4: 0.0%
Covered Lines: 6115
Relevant Lines: 6520

💛 - Coveralls

@CodyTseng CodyTseng changed the title fix: change repl() function param type to Type | DynamicModule fix(core): change repl() function param type to Type | DynamicModule Nov 1, 2022
@kamilmysliwiec
Copy link
Member

lgtm

@kamilmysliwiec kamilmysliwiec merged commit eaee2b9 into nestjs:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants