Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade axios to > 18.0 to fix security vulnerability #2322

Closed
shusson opened this issue May 31, 2019 · 7 comments
Closed

Upgrade axios to > 18.0 to fix security vulnerability #2322

shusson opened this issue May 31, 2019 · 7 comments
Labels
needs triage This issue has not been looked into

Comments

@shusson
Copy link

shusson commented May 31, 2019

Security vulnerability in axois <= 18.0.

See axios/axios#1098 (comment).

Not sure if/how nestjs wants these issues. I'm guessing the repo also has security alerts set up.

@shusson shusson added the needs triage This issue has not been looked into label May 31, 2019
@sajidali
Copy link

Got same report using snyk package. 👍 for report

@Toxicable
Copy link

Posting this here so others can find it easier

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ moderate      │ Denial of Service                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ axios                                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.18.1                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @nestjs/common                                               │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @nestjs/common > axios                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/880                         │
└───────────────┴──────────────────────────────────────────────────────────────┘

@sajidali
Copy link

sajidali commented Jun 4, 2019

@kamilmysliwiec PR> #2311 seems to fix this issue. any plans for releasing it?

@arjunyel
Copy link

arjunyel commented Jun 5, 2019

Automated fixes for next time 😄 https://github.blog/2019-05-23-introducing-new-ways-to-keep-your-code-secure/

@kamilmysliwiec
Copy link
Member

Fixed in the latest release

@ugolas
Copy link

ugolas commented Sep 8, 2019

can you guys fix this also in 5.x.x ?

@lock
Copy link

lock bot commented Dec 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

6 participants