Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fastify-adapter register func sign #10604 #10605

Merged
merged 1 commit into from Nov 29, 2022

Conversation

ufec
Copy link
Contributor

@ufec ufec commented Nov 26, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #10604

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ufec
Copy link
Contributor Author

ufec commented Nov 26, 2022

after run build, in example 10-fastify, is ok

@coveralls
Copy link

Pull Request Test Coverage Report for Build c99b302d-acdd-4ab3-b096-f9ad3e503c75

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.404%

Totals Coverage Status
Change from base Build a213a525-4c5b-48ee-9803-b76e72178509: 0.0%
Covered Lines: 6202
Relevant Lines: 6640

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 900be19 into nestjs:master Nov 29, 2022
@ufec
Copy link
Contributor Author

ufec commented Nov 29, 2022

It's a great honor to be a contributor, I'm using nestjs recently, I hope it will get better and better

@ufec ufec deleted the ufec-fix-10604-branch branch December 13, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants