Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I also get the type error using override, but not using app.register #10604

Closed
3 of 15 tasks
ufec opened this issue Nov 26, 2022 · 3 comments
Closed
3 of 15 tasks

I also get the type error using override, but not using app.register #10604

ufec opened this issue Nov 26, 2022 · 3 comments
Labels
needs triage This issue has not been looked into

Comments

@ufec
Copy link
Contributor

ufec commented Nov 26, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

I also get the type error using override, but not using app.register

Minimum reproduction code

https://stackblitz.com/edit/nestjs-typescript-starter-yffp2u?file=src%2Fmain.ts

Steps to reproduce

npm i -g @nestjs/cli
nest new test_helmet
cd test_helmet
npm uninstall @nestjs/platform-express && npm install --save @nestjs/platform-fastify fastify @fastify/helmet

In my last issue, adapter.register(fastifyHelmet) app.register(fastifyHelmet) will get type error, but now only at this time adapter.register(fastifyHelmet) occurs type error

async function bootstrap() {
  const adapter = new FastifyAdapter();
  await adapter.register(fastifyHelmet); // error
  const app = await NestFactory.create<NestFastifyApplication>(
    AppModule,
    adapter,
  );
  await app.register(fastifyHelmet); // success
  await app.listen(3000);
}
bootstrap();

Expected behavior

adapter.register(fastifyHelmet) and app.register(fastifyHelmet) is ok

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

No response

NestJS version

9.2.0

Packages versions

{
  "name": "nest-typescript-starter",
  "private": true,
  "version": "1.0.0",
  "description": "Nest TypeScript starter repository",
  "license": "MIT",
  "scripts": {
    "build": "nest build",
    "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
    "start": "nest start",
    "start:dev": "nest start --watch",
    "start:debug": "nest start --debug --watch",
    "start:prod": "node dist/main",
    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
    "test": "jest",
    "test:watch": "jest --watch",
    "test:cov": "jest --coverage",
    "test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand",
    "test:e2e": "jest --config ./test/jest-e2e.json"
  },
  "dependencies": {
    "@nestjs/common": "^9.0.0",
    "@nestjs/core": "^9.0.0",
    "@nestjs/platform-fastify": "^9.2.0",
    "fastify": "^4.10.2",
    "reflect-metadata": "^0.1.13",
    "rxjs": "^7.5.5"
  },
  "devDependencies": {
    "@nestjs/cli": "^9.0.0",
    "@nestjs/schematics": "^9.0.0",
    "@nestjs/testing": "^9.0.0",
    "@types/express": "^4.17.13",
    "@types/jest": "^28.1.4",
    "@types/node": "^18.0.3",
    "@types/supertest": "^2.0.12",
    "@typescript-eslint/eslint-plugin": "^5.30.5",
    "@typescript-eslint/parser": "^5.30.5",
    "eslint": "^8.19.0",
    "eslint-config-prettier": "^8.5.0",
    "eslint-plugin-prettier": "^4.2.1",
    "jest": "^28.1.2",
    "prettier": "^2.7.1",
    "source-map-support": "^0.5.21",
    "supertest": "^6.2.4",
    "ts-jest": "^28.0.5",
    "ts-loader": "^9.3.1",
    "ts-node": "^10.8.2",
    "tsconfig-paths": "^4.0.0",
    "typescript": "^4.7.4"
  },
  "jest": {
    "moduleFileExtensions": [
      "js",
      "json",
      "ts"
    ],
    "rootDir": "src",
    "testRegex": ".*\\.spec\\.ts$",
    "transform": {
      "^.+\\.(t|j)s$": "ts-jest"
    },
    "collectCoverageFrom": [
      "**/*.(t|j)s"
    ],
    "coverageDirectory": "../coverage",
    "testEnvironment": "node"
  },
  "overrides": {
    "@nestjs/platform-fastify": {
      "fastify": "$fastify"
    }
  }
}

Node.js version

16.17.0

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@ufec ufec added the needs triage This issue has not been looked into label Nov 26, 2022
@micalevisk
Copy link
Member

image

please update your reproduction. It doesn't work.

I know that I could install the dependencies myself but:

why reproductions are required

@ufec
Copy link
Contributor Author

ufec commented Nov 26, 2022

image

please update your reproduction. It doesn't work.

I know that I could install the dependencies myself but:

why reproductions are required

I tried to install it, but it doesn't work

@micalevisk
Copy link
Member

micalevisk commented Nov 26, 2022

yeah, I know. I just opened the reproduction you shared and it doesn't worked, like I said

kamilmysliwiec added a commit that referenced this issue Nov 29, 2022
fix: fastify-adapter register func sign #10604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

3 participants