Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plataform-express): replace any return type on #listen with Server #10481

Merged
merged 1 commit into from Nov 7, 2022

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #10480

image

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

coveralls commented Oct 30, 2022

Pull Request Test Coverage Report for Build ca801b5e-f0f1-4567-b1a4-c661deb3a4b1

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.788%

Totals Coverage Status
Change from base Build a1f147f5-1d97-43a6-8bf9-8ee0113704c9: 0.0%
Covered Lines: 6115
Relevant Lines: 6520

💛 - Coveralls

@micalevisk micalevisk changed the title feat(plataform-express): reply any return type on #listen feat(plataform-express): replace any return type on #listen Oct 30, 2022
@micalevisk micalevisk changed the title feat(plataform-express): replace any return type on #listen feat(plataform-express): replace any return type on #listen with Server Oct 30, 2022
@kamilmysliwiec kamilmysliwiec merged commit e04e414 into nestjs:master Nov 7, 2022
@kamilmysliwiec
Copy link
Member

lgtm

@micalevisk micalevisk deleted the feat/issue-10480 branch November 7, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underlying HttpServer is of type any
3 participants