Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): display class's name on request mapping exceptions #10479

Merged

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Oct 29, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

If we have an invalid controller class listed in some controllers array, we'll got this error:

image

image

What is the new behavior?

Now the error will looks like this:

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Also, I've leverage on this PR to increase the code coverage on /core/exceptions a bit as well because why not 🐱

before

image

now

image

@coveralls
Copy link

coveralls commented Oct 29, 2022

Pull Request Test Coverage Report for Build 7ab0292e-1fd4-425a-98f3-ce3c5d250a8e

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.804%

Totals Coverage Status
Change from base Build a1f147f5-1d97-43a6-8bf9-8ee0113704c9: 0.02%
Covered Lines: 6116
Relevant Lines: 6520

💛 - Coveralls

@micalevisk micalevisk force-pushed the feat/verbose-wrong-controller-error branch from d04f29a to 8af21d1 Compare October 29, 2022 19:58
@micalevisk micalevisk force-pushed the feat/verbose-wrong-controller-error branch from 2b4087f to 1d8c56a Compare October 29, 2022 22:38
@kamilmysliwiec kamilmysliwiec merged commit dc2582a into nestjs:master Nov 7, 2022
@micalevisk micalevisk deleted the feat/verbose-wrong-controller-error branch November 7, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants