Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(microservices): update server properties to protected #10371

Merged
merged 1 commit into from Oct 21, 2022

Conversation

barlock
Copy link
Contributor

@barlock barlock commented Oct 5, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

TCP server and mqtt client were private so subclasses couldn't access them.

I peered through a few of the other servers and clients, this seems to follow patterns I've seen.

What is the new behavior?

downstream projects can subclass and access the server and client directly! YEY!.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build c777d6b3-63c5-46f4-9d8d-3aadaf033241

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.786%

Totals Coverage Status
Change from base Build 6b637f64-9c7a-4d7b-8537-b6a8d098f58e: 0.0%
Covered Lines: 6113
Relevant Lines: 6518

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

lgtm

@kamilmysliwiec kamilmysliwiec merged commit 11fcaa2 into nestjs:master Oct 21, 2022
@barlock barlock deleted the refactor-private-fields branch October 25, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants