Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow passing arguments to nest start <app> #1847

Merged
merged 1 commit into from Dec 27, 2022

Conversation

alko89
Copy link
Contributor

@alko89 alko89 commented Dec 11, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Before this start command was not able to pass additional arguments to <app>

Issue Number: #1844

What is the new behavior?

You can now pass additional arguments to <app> after the -- argument.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec
Copy link
Member

lgtm

zackdotcomputer added a commit to zackdotcomputer/nest-cli that referenced this pull request Aug 15, 2023
Commander requires an explicit call to `allowUnknownOption` to allow and not error on options it does not recognize. This causes an issue with [this functionality](nestjs#1847) because any user-defined flags are blocked at the command level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants