Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pnpm install flags #1820

Merged
merged 1 commit into from Oct 27, 2022

Conversation

jmcdo29
Copy link
Member

@jmcdo29 jmcdo29 commented Oct 27, 2022

pnpm v7.0.0 until 7.13.5 uses --strict-peer-dependencies=true which causes a failure when not all peerDependencies are installed. By setting the flag explicitly, this will no longer be a problem for new users.

fix: #1806

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

When a user uses pnpm 7.0.0 to 7.13.5 the install portion of nest new fails because of the strict-peer-dependencies option being set inherently to true, as we do not add every peer dependency to the package.json

Issue Number: #1806

What is the new behavior?

nest new will no longer fail for pnpm v7.0.0 to 7.13.5. Later versions it should be set to false by default anyways

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

pnpm v7.0.0 until 7.13.5 uses `--strict-peer-dependencies=true` which causes
a failure when not all `peerDependencies` are installed. By setting the
flag explicitly, this will no longer be a problem for new users.

fix: nestjs#1806
@kamilmysliwiec
Copy link
Member

lgtm

@kamilmysliwiec kamilmysliwiec merged commit 9594c91 into nestjs:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to execute command: pnpm install --reporter=silent
2 participants