-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"add" command doesn't follow skip-install convention. #1809
Comments
I'm happy to pick this one up! |
but that's not a valid option for nest-cli/commands/add.command.ts Lines 9 to 17 in 75e7a62
Run |
Hey @micalevisk! Thank you, yeah I probably should have filed this as a feature request as opposed to bug: I noted my reasoning for the decision to go with "bug" in the "Other" section of the report but I certainly understand exactly where you're coming from. |
Sounds like a good feature. Feel free to open a PR anytime, thanks 😺 |
Related PR: #1810 |
Let's track this here #1810 |
Is there an existing issue for this?
Current behavior
does not skip installation, nor does --skipInstall (which is documented in @nestjs libraries such as azure-func-http)
Minimum reproduction code
n/a
Steps to reproduce
Install a package (here the reason is because the legacy-peer-deps flag was needed):
npm install --save @nestjs/azure-func-http --legacy-peer-deps
.Attempt to utilize schematic with "add" action:
nest add @nestjs/azure-func-http --skip-install
.Optional: Attempt skipInstall as documented in the above @nestjs library:
nest add @nestjs/azure-func-http --skip-install
.Expected behavior
Successful schematic build.
(e.g.)
Package version
9.1.4
NestJS version
9.1.4
Node.js version
16.16.0
In which operating systems have you tested?
Other
This may technically be more of a feature request; however as it would be more conventional and the aforementioned documentation in @nestjs libraries regarding skipping installation makes this seem like it falls more into the "bug" category.
Happy to pick this one up.
The text was updated successfully, but these errors were encountered: