Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package name selection for application schematics #1803

Merged

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Oct 1, 2022

(it is #1585 but now I'm trying to participate on Hacktoberfest 2022 haha)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: fixes nestjs/schematics#249 (and closes #500)

demo
old.mp4

What is the new behavior?

The packageManager option on application schematics is defined by -p/--package-manager or by the selector prompted to the user. Using npm by default, as usual

demo
now.mp4

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I choose to not apply any refactoring to the code (like I did on PR #1457) to make diff cleaner and easy to follow

As the `application` schematics on `@nestjs/schematics` defines the name
`packageManager` to select the package manager to use, we could use pass
it directly from `nest new` command.
@kamilmysliwiec kamilmysliwiec merged commit bd7a59f into nestjs:master Dec 27, 2022
@kamilmysliwiec
Copy link
Member

lgtm

@micalevisk micalevisk deleted the fix-support-package-manager-selection branch December 27, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect README.md commands for yarn
4 participants