Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tsconfig.json by default if tsconfig.build.json not exist #1780

Merged
merged 2 commits into from Sep 12, 2022

Conversation

zanminkian
Copy link
Contributor

@zanminkian zanminkian commented Sep 8, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Some simple and small project only use tsconfig.json and have no tsconfig.build.json on the root of project. It will throw an error if developer execute nest build on the root. They have to execute nest build -p tsconfig.json, which is not simple and clean. Moreover, some developer who is new to TypeScript only know tsconfig.json and don't know what is tsconfig.build.json.

What is the new behavior?

Execute nest build will not throw error if there is only tsconfig.json.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zanminkian
Copy link
Contributor Author

zanminkian commented Sep 8, 2022

Unit tests in CI will fail because of some cases will fail on master branch. Seems not caused by this PR.

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 649ec08 into nestjs:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants