From 11d551b789b971c2ef7e6f0a0020461f1e29268c Mon Sep 17 00:00:00 2001 From: "Micael Levi (@micalevisk)" Date: Thu, 24 Mar 2022 22:55:32 -0400 Subject: [PATCH] refactor: remove dead code on `new` action packages installation --- actions/new.action.ts | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/actions/new.action.ts b/actions/new.action.ts index 46b33ae7f..231733ebd 100644 --- a/actions/new.action.ts +++ b/actions/new.action.ts @@ -144,9 +144,7 @@ const installPackages = async ( dryRunMode: boolean, installDirectory: string, ) => { - const inputPackageManager: string = options.find( - (option) => option.name === 'packageManager', - )!.value as string; + const inputPackageManager = getPackageManagerInput(options)!.value as string; let packageManager: AbstractPackageManager; if (dryRunMode) { @@ -155,29 +153,16 @@ const installPackages = async ( console.info(); return; } - if (inputPackageManager !== undefined) { - try { - packageManager = PackageManagerFactory.create(inputPackageManager); - await packageManager.install(installDirectory, inputPackageManager); - } catch (error) { - if (error && error.message) { - console.error(chalk.red(error.message)); - } + try { + packageManager = PackageManagerFactory.create(inputPackageManager); + await packageManager.install(installDirectory, inputPackageManager); + } catch (error) { + if (error && error.message) { + console.error(chalk.red(error.message)); } - } else { - packageManager = await selectPackageManager(); - await packageManager.install( - installDirectory, - packageManager.name.toLowerCase(), - ); } }; -const selectPackageManager = async (): Promise => { - const answers: Answers = await askForPackageManager(); - return PackageManagerFactory.create(answers['packageManager']); -}; - const askForPackageManager = async (): Promise => { const questions: Question[] = [ generateSelect('packageManager')(MESSAGES.PACKAGE_MANAGER_QUESTION)([