Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test notifications on failure #1152

Merged
merged 1 commit into from Dec 9, 2022
Merged

Fix test notifications on failure #1152

merged 1 commit into from Dec 9, 2022

Conversation

shnela
Copy link
Contributor

@shnela shnela commented Dec 8, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 8, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@c849b7e). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7e6b2db differs from pull request most recent head 6b04f0f. Consider uploading reports for the commit 6b04f0f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1152   +/-   ##
=========================================
  Coverage          ?   88.06%           
=========================================
  Files             ?       98           
  Lines             ?     5537           
  Branches          ?      630           
=========================================
  Hits              ?     4876           
  Misses            ?      273           
  Partials          ?      388
Flag Coverage Δ
unit 88.06% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shnela shnela changed the title Test notifications Fix test notifications on failure Dec 8, 2022
Raalsky
Raalsky reviewed Dec 9, 2022
View reviewed changes
.github/workflows/e2e.yml
@@ -129,7 +129,7 @@ jobs:
e2e-tests-notify:
needs: [ e2e, e2e_management, e2e_s3_gcs, e2e_s3 ]
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/master'
if: (success() || failure()) && github.ref == 'refs/heads/master'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isin't it the same as always()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always() additionally ignores manual cancellation of workflow.

@shnela shnela merged commit 81e5857 into master Dec 9, 2022
@shnela shnela deleted the jk/test-notify branch December 9, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raalsky Raalsky Raalsky left review comments

@PatrykGala PatrykGala PatrykGala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shnela @Raalsky @PatrykGala