Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate timeline metadata to JSON #7540

Open
skyzh opened this issue Apr 29, 2024 · 2 comments
Open

migrate timeline metadata to JSON #7540

skyzh opened this issue Apr 29, 2024 · 2 comments
Assignees
Labels
c/storage/pageserver Component: storage: pageserver t/feature Issue type: feature, for new features or requests

Comments

@skyzh
Copy link
Member

skyzh commented Apr 29, 2024

It's painful to keep forward+backward compatibility now because we serialize the timeline metadata directly using the in-memory format. By using JSON, we can always add Option<X> to the metadata. These fields will be skipped when read from an older version of pageserver, and will be picked up in the new version, and therefore easy to keep forward/backward compatibility.

@skyzh skyzh added t/feature Issue type: feature, for new features or requests c/storage/pageserver Component: storage: pageserver labels Apr 29, 2024
@skyzh
Copy link
Member Author

skyzh commented Apr 29, 2024

encountered this problem when adding feature flag for #7462

@skyzh
Copy link
Member Author

skyzh commented May 14, 2024

resolved with #7693

@jcsp jcsp assigned koivunej and unassigned skyzh May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/pageserver Component: storage: pageserver t/feature Issue type: feature, for new features or requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants