Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify if public class fields work now using webpack based builds #1866

Closed
tobiu opened this issue Apr 25, 2021 · 1 comment
Closed

verify if public class fields work now using webpack based builds #1866

tobiu opened this issue Apr 25, 2021 · 1 comment
Assignees
@tobiu
Labels
enhancement New feature or request
Projects
v2.1

Comments

@tobiu
Copy link
Collaborator

tobiu commented Apr 25, 2021

not a perfect timing right after the v2 release, but just got an update on this topic:
webpack/webpack#10216 (comment)

will do a quick test (upgraded to webpack v5.35.1).
@tobiu tobiu added the enhancement New feature or request label Apr 25, 2021
@tobiu tobiu self-assigned this Apr 25, 2021
@tobiu tobiu added this to To do in v2.1 via automation Apr 25, 2021
tobiu added a commit that referenced this issue Apr 25, 2021
@tobiu
#1866 multiWindow.ViewportController: changed one config to a public …
009920a 
…class field
tobiu added a commit that referenced this issue Apr 25, 2021
@tobiu
#1866 added the 2 multiWindow apps to the build.json
cc1c775
tobiu added a commit that referenced this issue Apr 25, 2021
@tobiu
#1866 build.json added the shared workers build setting
417b7ea
tobiu added a commit that referenced this issue Apr 25, 2021
@tobiu
#1866 multiWindow.ViewportController: cleanup
52c3ba8
@tobiu
Copy link
Collaborator Author

tobiu commented Apr 25, 2021

Screenshot 2021-04-25 at 10 27 11

Screenshot 2021-04-25 at 10 22 42

Screenshot 2021-04-25 at 10 25 50

this looks good!

@tobiu tobiu closed this as completed Apr 25, 2021
v2.1 automation moved this from To do to Done Apr 25, 2021
tobiu added a commit that referenced this issue Apr 25, 2021
@tobiu
#1866 multiWindow.ViewportController: changed connectedApps into a pu…
4a40a1a 
…blic class field
tobiu added a commit that referenced this issue Apr 25, 2021
@tobiu
#1866 multiWindow.MainContainerController: changed dialog into a publ…
f9327a8 
…ic class field
tobiu added a commit that referenced this issue Apr 25, 2021
@tobiu
#1866 removed a not need comma inside the index.html files
50537d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiu tobiu

Labels
enhancement New feature or request
Projects
No open projects
v2.1
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobiu