zN<CR> only if preview window is a horizontal split #2306
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using "coc.preferences.hoverTarget": "preview", coc sets the preview window height with zN<CR>. The problem is that it reduces the height of the window even if there is no window adjacent to the top/bottom current window, which is undesirable. Therefore, it first need to check that there is a adjacent window.
|
Note: Direction parameter for |
chemzqm
pushed a commit
that referenced
this pull request
Sep 10, 2020
When using "coc.preferences.hoverTarget": "preview", coc sets the preview window height with zN<CR>. The problem is that it reduces the height of the window even if there is no window adjacent to the top/bottom current window, which is undesirable. Therefore, it first need to check that there is a adjacent window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using "coc.preferences.hoverTarget": "preview", coc sets the preview window height with
zN<CR>. The problem is that it reduces the height of the window even if there is no window adjacent to the top/bottom current window, which is undesirable. Therefore, it first need to check that there is a adjacent window.For example this is what you'll get if you move the preview window to the right size and then do hover.
