Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings: types export #470

Merged
merged 2 commits into from Aug 29, 2019
Merged

Fix typings: types export #470

merged 2 commits into from Aug 29, 2019

Conversation

thebestnom
Copy link
Contributor

exporting typeof Node, Relationship etc...
as you put it typescript thinks you export a Node with type Node instead of the actual class
(same for the rest of the types object)

@thebestnom
Copy link
Contributor Author

thebestnom commented Jun 11, 2019

I cant see the details on why the commit is failing, can someone check for me?

@ali-ince
Copy link
Contributor

Hi @thebestnom,

Thanks for your contribution.

You should sign the CLA to get your changes to be tested by our CI and eventually get it merged. Please follow instructions mentioned here and then we'll be able to trigger the CI checks.

It would be great if you could rebase your PR as well.

Thanks.

exporting typeof Node, Relationship etc...
@thebestnom
Copy link
Contributor Author

thebestnom commented Aug 28, 2019

waiting for response from CLA maintainers, but did everything for now!
@ali-ince

@ali-ince
Copy link
Contributor

Thanks @thebestnom for the contribution, everything sorted out. Builds with 4.0 fail because we don't test 1.7 branch against 4.0 server for the time being.

@ali-ince ali-ince merged commit c5c0094 into neo4j:1.7 Aug 29, 2019
@thebestnom thebestnom deleted the patch-1 branch October 8, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants