Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve package is breaking after 1.11.0 change, don't update it for now #1433

Closed
danwbyrne opened this issue Jun 5, 2019 · 0 comments
Closed

resolve package is breaking after 1.11.0 change, don't update it for now #1433

danwbyrne opened this issue Jun 5, 2019 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@danwbyrne
Copy link
Contributor

danwbyrne commented Jun 5, 2019 •
edited

Description

Not sure what they changed, but the overall calling order of resolve to our mock filesystem in tests is very broken. When compared to how it operated (side-by-side with another version running) they touched different mock filesystem methods completely. Ignoring for now as it isn't pressing that we update it anyway.

Steps to Reproduce

  1. update to resolve 1.11.1 in @neo-one/editor
  2. tests fail

see: browserify/resolve#192

edit: this is actually coming up when cascading to other packages like webpack, putting it in the resolutions package field for now.
@danwbyrne danwbyrne added kind/bug Categorizes issue or PR as related to a bug. open for discussion labels Jun 5, 2019
@danwbyrne danwbyrne mentioned this issue Jun 5, 2019
Merged
bors bot added a commit that referenced this issue Jun 5, 2019
@bors @danwbyrne
Merge #1436
841db0c 
1436: fix(web): update website docs with @neo-one/suite r=danwbyrne a=danwbyrne

update tutorial document with `@neo-one/suite` reference.

Add `resolve` as a resolution, see #1433

(also put our resolutions in alphabetical order)

Co-authored-by: Daniel Byrne <danwbyrne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dicarlo2 @danwbyrne