Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure due to reference to crypto module #5

Closed
pospi opened this issue Jan 21, 2023 · 4 comments
Closed

Compilation failure due to reference to crypto module #5

pospi opened this issue Jan 21, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@pospi
Copy link
Collaborator

pospi commented Jan 21, 2023

This is a weird one that manifests as a 404 request to http://localhost:8000/__wds-outside-root__/6/__web-dev-server__/rollup/node-resolve:empty.js?web-dev-server-rollup-null-byte=%00node-resolve%3Aempty.js

I was able to track this down to an import of the (deprecated) nodejs crypto module. Does not appear in the package manifest or lockfile. Very odd. Potentially due to @holochain/client's import of tweetnacl. I'm working through updating the client libs to see if this resolves the issue as I currently have two versions of @holochain/client being loaded, and the more recent one (coming from @vf-ui/graphql-client-holochain) is probably the more correct one.

@pospi pospi added the bug Something isn't working label Jan 21, 2023
@pospi pospi self-assigned this Jan 21, 2023
@pospi
Copy link
Collaborator Author

pospi commented Jan 21, 2023

Hmm, lots to coordinate here. It seems that @neighbourhoods/sensemaker-lite-types also depends on an older @holochain/client.

@weswalla are you already working through these updates? If so I can wait...

@pospi
Copy link
Collaborator Author

pospi commented Jan 21, 2023

Actually sorry ignore that, looks like you already dealt with the types repo in 0.1.0 and I just needed to update that version here. @neighbourhoods/nh-we-applet and all of the @holochain-open-dev packages were suffering a similar issue and also needed to be updated.

@holochain-open-dev/cell-client is still a problem and references "@holochain/client": "^0.10.2".

@pospi
Copy link
Collaborator Author

pospi commented Jan 27, 2023

Interestingly I am not hitting this with #7 anymore, even though @vf-ui/vf-graphql-holochain still depends on @holochain/client@0.11.9, which has tweetnacl (and crypto) as a dependency (this has been the case since 0.10.0).

It may be the case that some configuration between the WDS (now removed in #7) and Rollup development tooling regarding nodejs builtins was causing this issue.

Will leave this open until #7 is merged and confirmed working as we still have some decisions to make there.

@pospi
Copy link
Collaborator Author

pospi commented Feb 5, 2023

Seems fine for now, but could be an artifact of #9.

@pospi pospi closed this as completed Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant