Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skip_empty have an effect on XML reporting #976

Closed
ilkecan opened this issue Apr 18, 2020 · 2 comments
Closed

Make skip_empty have an effect on XML reporting #976

ilkecan opened this issue Apr 18, 2020 · 2 comments
Labels
enhancement New feature or request fixed xml

Comments

@ilkecan
Copy link

ilkecan commented Apr 18, 2020

Is your feature request related to a problem? Please describe.
It seems setting skip_empty to True in .coveragerc has no effect on XML reporting.

Describe the solution you'd like
I would like setting skip_empty to True to actually skip the empty files during XML reporting.

Describe alternatives you've considered
I can currently omit the empty files, but this not very convenient.

Additional context
I have empty __init__.py files in my project (they are actually only created because Coverage.py requires them to include un-tested files in those directories in the report.) and when I generate an XML report while skip_empty is set to True, those empty files are also in the report. As a result, cobertura plug-in in Jenkins shows wrong results (this might be unrelated).

@ilkecan ilkecan added the enhancement New feature or request label Apr 18, 2020
@nedbat nedbat added the xml label Jun 30, 2020
@nedbat
Copy link
Owner

nedbat commented Jun 30, 2020

This is fixed in 97f05c9

@nedbat nedbat closed this as completed Jun 30, 2020
@nedbat nedbat added the fixed label Jun 30, 2020
@nedbat
Copy link
Owner

nedbat commented Jul 6, 2020

This is now released as part of coverage 5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed xml
Projects
None yet
Development

No branches or pull requests

2 participants