Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to alter the paths config #969

Merged
merged 1 commit into from Apr 11, 2020
Merged

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Apr 3, 2020

Resolves #967.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #969 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
+ Coverage   94.00%   94.04%   +0.03%     
==========================================
  Files          86       86              
  Lines       12107    12121      +14     
  Branches     1212     1214       +2     
==========================================
+ Hits        11381    11399      +18     
+ Misses        590      588       -2     
+ Partials      136      134       -2     
Impacted Files Coverage Δ
coverage/config.py 98.43% <100.00%> (+0.03%) ⬆️
tests/test_config.py 100.00% <100.00%> (ø)
tests/test_arcs.py 100.00% <0.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64bd04c...edadbec. Read the comment docs.

@gaborbernat
Copy link
Contributor Author

@nedbat any chance to land this? 🤔

@nedbat
Copy link
Owner

nedbat commented Apr 11, 2020

Thanks, this fixes an oversight. If you don't mind me asking, what plugin will you use it for?

@nedbat nedbat merged commit 97997d2 into nedbat:master Apr 11, 2020
@gaborbernat
Copy link
Contributor Author

covdefaults, linked in the issue.

@gaborbernat gaborbernat deleted the 967 branch April 11, 2020 19:30
@nedbat
Copy link
Owner

nedbat commented Apr 12, 2020

This is available in 5.1: https://pypi.org/project/coverage/5.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paths cannot be altered by plugins
3 participants