Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create-react-app to use babel-plugin-react-native-web #629

Closed
necolas opened this issue Sep 13, 2017 · 5 comments
Closed

Update create-react-app to use babel-plugin-react-native-web #629

necolas opened this issue Sep 13, 2017 · 5 comments
Labels
needs: help

Comments

@necolas
Copy link
Owner

necolas commented Sep 13, 2017

React Native for Web now exports a Babel plugin that sets up aliasing of the package and excludes any unused modules from builds. We should create a PR for create-react-app to rely on this instead of the webpack alias, as builds will be faster and smaller. AFAIK, the Jest package aliasing might also be unnecessary afterwards.
@ansumanshah
Copy link

ansumanshah commented Sep 13, 2017 •
edited

We should have something like babel-plugin-react-native-web so that create-react-app does not have to download the whole package as a dependency to setup the plugin.

@necolas necolas changed the title Update create-react-app to use react-native-web/babel Update create-react-app to use babel-plugin-react-native-web Dec 24, 2017
@necolas
Copy link
Owner Author

necolas commented Dec 24, 2017

The next minor release – 0.3.0 – will include a new package babel-plugin-react-native-web that will unblock this task.

Configure the preset…

It's a plugin rather than a preset

@necolas
Copy link
Owner Author

necolas commented Jan 11, 2018

If someone wants to take this on and add it to the next release of CRA… facebook/create-react-app#3672

Repository owner deleted a comment from tanneess Feb 21, 2018
Repository owner deleted a comment from ararog Feb 21, 2018
Repository owner deleted a comment from ararog Feb 21, 2018
Repository owner deleted a comment from Stas-Buzunko Feb 21, 2018
@paularmstrong paularmstrong mentioned this issue Mar 8, 2018
Closed
@paularmstrong
Copy link
Contributor

In progress at: facebook/create-react-app#4125

paularmstrong added a commit to paularmstrong/create-react-app that referenced this issue Mar 17, 2018
@paularmstrong
Use babel-plugin-react-native-web instead of webpack alias
f2c7933 
Fixes necolas/react-native-web#629
@necolas
Copy link
Owner Author

necolas commented Mar 31, 2018

Thanks. Closing this tracking issue

@necolas necolas closed this as completed Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paularmstrong @necolas @ansumanshah