Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many pull requests in the done column #152

Closed
simoneb opened this issue Oct 26, 2022 · 3 comments
Closed

Too many pull requests in the done column #152

simoneb opened this issue Oct 26, 2022 · 3 comments
Assignees

Comments

@simoneb
Copy link
Member

simoneb commented Oct 26, 2022

When using this app we're getting lots of pull requests in the done column of the board. This is not really expected because it doesn't look like CI ever failed for those pull requests.

I wonder if PRs are being added to the board in circumstances other than CI failing for them.

@brunopascottini
Copy link

brunopascottini commented Nov 16, 2022

Information related to PRs opened by dependabot will be tracked in this spreadsheet

@simoneb
Copy link
Member Author

simoneb commented Nov 18, 2022

post your findings here please

@brunopascottini
Copy link

brunopascottini commented Nov 18, 2022

I analysed all the Pull Requests created by dependabot currently in the bench board and every one of them had a failing workflow at some point, therefore I conclude that the issue is not related to unbreakci. Around 10% of these PR were actual issues with Build or Test commands. The significant others were grouped in three major categories:

Pull Request is not mergeable: Where the action tried to merge before the approved status of the PR, probably related to GitHub. No action was taken.

GitHub sync: Where workflow didn't wait for a prior job used in needs field, also probably related to GitHub synchronisation. No action was taken.

PR is not from Dependabot, nothing to do: Missing filter on push to master/main branch was triggering the workflow incorrectly and actions used in this composite were failing. Workflows within this category were updated in the repositories present in the spreadsheet. I'll keep an eye for future ones. A Pull Request was submitted to update the readme of the action with correct filters.

@simoneb simoneb closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants