Fix: external linked issues notification #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameer-coder
force-pushed
the
fix-external-linked-issues
branch
from
1c5a7c2
to
0cffb01
Compare
simoneb
approved these changes
Nov 22, 2022
| @@ -3,7 +3,7 @@ | |||
| const md = require('markdown-it')() | |||
|
|
|||
| function getPrNumbersFromReleaseNotes(releaseNotes) { | |||
| const parsedReleaseNotes = md.parse(releaseNotes) | |||
| const parsedReleaseNotes = md.parse(releaseNotes, {}) | |||
There was a problem hiding this comment.
This was throwing the js error in #180. As per MarkdownIt docs the parse method needs 2 args
MarkdownIt.parse(src, env) --> Array
This was referenced Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues #179 and #180
The action was failing when trying to create a comment on an issue linked to an external repository. That error is handled correctly now and the action no longer fails.
closes #179
closes #180