Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize epoch configs #11265

Open
Longarithm opened this issue May 8, 2024 · 0 comments
Open

Standardize epoch configs #11265

Longarithm opened this issue May 8, 2024 · 0 comments
Labels
A-stateless-validation Area: stateless validation C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. C-housekeeping Category: Refactoring, cleanups, code quality

Comments

@Longarithm
Copy link
Member

Longarithm commented May 8, 2024

EpochConfigs has to be stored and created in the similar fashion as RuntimeConfigStore: folder with YAML configs, each corresponding to its own protocol version. Currently it's quite hard to understand what are the values of fields because they are overridden in many places. Somewhere we even just use constants.

Genesis shouldn't be source of truth because we keep adding new fields there.

More specifically - logic in AllEpochConfig is quite chaotic, e.g. AllEpochConfigTestOverrides applies changes on top of all versions of epoch configs. Not sure if min_stake_ratio must be used in all tests, etc.

Example of relevant work #11252

@Longarithm Longarithm added C-housekeeping Category: Refactoring, cleanups, code quality C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. A-stateless-validation Area: stateless validation labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

No branches or pull requests

1 participant