Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change validator assignment to consider all validator proposals instead of chunk producer only #11202

Closed
walnut-the-cat opened this issue May 1, 2024 · 0 comments · Fixed by #11252
Closed

Change validator assignment to consider all validator proposals instead of chunk producer only #11202

walnut-the-cat opened this issue May 1, 2024 · 0 comments · Fixed by #11252
Assignees
@Longarithm
Labels
A-stateless-validation Area: stateless validation

Comments

@walnut-the-cat
Copy link
Contributor

walnut-the-cat commented May 1, 2024 •
edited

We need to make sure

  1. number of block producers are same as number of chunk producers
  2. no more chunk only producer role
  3. chunk validators consider entire validator pool instead of chunk producer pool
@walnut-the-cat walnut-the-cat added the A-stateless-validation Area: stateless validation label May 1, 2024
@walnut-the-cat walnut-the-cat mentioned this issue May 6, 2024
Closed
@Longarithm Longarithm linked a pull request May 7, 2024 that will close this issue
feat: consider all proposals for chunk validators #11252
Merged
@Longarithm Longarithm mentioned this issue May 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 15, 2024
@Longarithm
feat: consider all proposals for chunk validators (#11252)
7befdbd 
Solve #11202 and continue simplifying proposals processing logic.

I want to make epoch info generation as straightforward as possible, by
moving code for old protocol versions to local submodule so it won't be
distracting. Now it should be more clear that epoch info generation
consists of couple independent steps.

Couple notes:
* FixStakingThreshold isn't stabilised so we can use whatever protocol
version. Version of epoch being generated makes much more sense.
* I expected chunk validators set to be the biggest, but there is subtle
case when we can't select chunk validators due to small stake ratio but
can select chunk producers instead. It adds a bit of complexity.
* There is subtle change in validator indexing and I believe the new
indexing - basically, sorting by descending stake in majority of cases -
makes more sense.

---------

Co-authored-by: Longarithm <the.aleksandr.logunov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Longarithm Longarithm

Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: consider all proposals for chunk validators Longarithm/nearcore
3 participants
@Longarithm @shreyan-gupta @walnut-the-cat