-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push Notifications do not contain value.item.BlockHeight #658
Comments
@gagdiez our queryAPI indexer for notifications does store the blockheight. Are you suggesting the actual push event which is sent to a client should contain the blockheight as well? |
@charleslavon indeed, without the |
The "Somebody liked the specific post" also is working fine since in the notification we can see who liked our post. The "Post not found" issue is still happening when we try to view the post after clicking specific like action in notification. It seems to be a problem with the indexer. |
There is no mixture and confusion, it is clear that they are two different things:
|
The current implementation is correct. There is a |
You can see in line 92 that it is not: In my service worker, when somebody likes one of my posts, I get this info:
The The current notification tells me that somebody liked one of my posts, but it does not tell me which post was liked (in this case, the post uniquely identified by the tuple: |
@gagdiez let's consider this for a future sprint |
@gagdiez you're totally right. I checked that on my fork of |
Hey @gagdiez! The |
@shelegdmitriy perfect, will test it after EthDenver, thank you so much! |
When a user is notified on
near.social
, the notification includes anitem
that contains:type
of the notification (e.g.like
)path
to the element being likedblockHeight
that represents such elementHere is a complete notification, as retrieved by
near.social
:Currently, our push notifications are missing the
value.item.blockHeight
, which is important to know which element is being "liked" (or acted upon)One would expect to either get all the
item
information, or the notification blockheight. It seams that currently we have a mixture of both.The text was updated successfully, but these errors were encountered: