Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement const-generics under feature #38

Merged
merged 5 commits into from Jul 14, 2021
Merged

Conversation

austinabell
Copy link
Contributor

Put it under feature to not force any breaking changes, let me know if you want me to add const-generics to the default feature list to start the phase-out. I figured not yet because it's only 2 releases ago, but I don't have an opinion.

closes #32

Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ailisp
Copy link
Member

ailisp commented Jul 12, 2021

@frol do you have some comments on this? Thanks

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's keep it under a non-default feature flag for a while 👍

@frol frol merged commit 88459fc into master Jul 14, 2021
@frol
Copy link
Collaborator

frol commented Jul 14, 2021

I cut 0.9.1 release for borsh-rs.

@frol frol mentioned this pull request May 31, 2023
@frol frol deleted the austin/const-generics branch June 2, 2023 20:04
@frol frol mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Const generics support
3 participants