Fix bug in default readable output port #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertfrees
added a commit
to daisy/xmlcalabash1
that referenced
this pull request
Aug 19, 2020
|
Applied to version 1.2.5 for Saxon 9.9 and Saxon 10.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry that I don't have a better description of the problem. I spent some time trying to reproduce the issue with a simple test case but I didn't manage to. All I can say is that in some of my pipelines the issue occurred that no automatic connection was made where you would expect one to be made, and there was no reason whatsoever why it should behave like it did. To me it was quite clear that is was a bug.
My patch fixes the problem. Unfortunately I can't explain what I did because it's hard to understand what is going on in that code. On the bright side, I have been using it for a while though and there don't seem to be any negative side effects for me, which makes me confident that it didn't screw up.
I'm hoping that you do understand the code and can confirm that I indeed fixed a bug, and that you are willing to accept the patch as is.