From 7a5da861eede8ba2507aaf93ac1fc0b50fe4aabd Mon Sep 17 00:00:00 2001 From: Nicolas De Loof Date: Wed, 6 Jul 2022 09:58:10 +0200 Subject: [PATCH] compute image VirutalSize Signed-off-by: Nicolas De Loof --- daemon/containerd/service.go | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/daemon/containerd/service.go b/daemon/containerd/service.go index ccd545d800907..059312b919470 100644 --- a/daemon/containerd/service.go +++ b/daemon/containerd/service.go @@ -6,6 +6,7 @@ import ( "github.com/containerd/containerd" "github.com/containerd/containerd/platforms" + "github.com/containerd/containerd/snapshots" "github.com/docker/distribution" "github.com/docker/distribution/reference" "github.com/docker/docker/api/types" @@ -20,6 +21,7 @@ import ( "github.com/docker/docker/image" "github.com/docker/docker/layer" "github.com/opencontainers/go-digest" + "github.com/opencontainers/image-spec/identity" ocispec "github.com/opencontainers/image-spec/specs-go/v1" ) @@ -68,19 +70,25 @@ func (cs *containerdStore) Images(ctx context.Context, opts types.ImageListOptio } var ret []*types.ImageSummary + snapshotter := cs.client.SnapshotService(containerd.DefaultSnapshotter) for _, image := range images { size, err := image.Size(ctx) if err != nil { return nil, err } + virtualSize, err := computeVirtualSize(ctx, image, snapshotter) + if err != nil { + return nil, err + } + ret = append(ret, &types.ImageSummary{ RepoDigests: []string{image.Name() + "@" + image.Target().Digest.String()}, // "hello-world@sha256:bfea6278a0a267fad2634554f4f0c6f31981eea41c553fdf5a83e95a41d40c38"}, RepoTags: []string{image.Name()}, Containers: -1, ParentID: "", SharedSize: -1, - VirtualSize: 10, + VirtualSize: virtualSize, ID: image.Target().Digest.String(), Created: image.Metadata().CreatedAt.Unix(), Size: size, @@ -90,6 +98,22 @@ func (cs *containerdStore) Images(ctx context.Context, opts types.ImageListOptio return ret, nil } +func computeVirtualSize(ctx context.Context, image containerd.Image, snapshotter snapshots.Snapshotter) (int64, error) { + var virtualSize int64 + diffIDs, err := image.RootFS(ctx) + if err != nil { + return virtualSize, err + } + for _, chainID := range identity.ChainIDs(diffIDs) { + usage, err := snapshotter.Usage(ctx, chainID.String()) + if err != nil { + return virtualSize, err + } + virtualSize += usage.Size + } + return virtualSize, nil +} + func (cs *containerdStore) LogImageEvent(imageID, refName, action string) { panic("not implemented") }