Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore prerelease on update #96

Merged
merged 3 commits into from Aug 1, 2021

Conversation

jashandeep-sohi
Copy link
Contributor

Hi,

This adds a omitPrereleaseDuringUpdate option, that should allow you to preserve the prerelease state on updates.

@ncipollo
Copy link
Owner

Could you elaborate a little bit on the use case? Is there a scenario where you would want to create the release with the pre-release flag set to true but omit it when you update the release?

@jashandeep-sohi
Copy link
Contributor Author

To me updating a release is completely orthogonal to its prerelease status. For example, I create a prerelease v1.2-alpha in one workflow and in another upload additional assets for that release. That shouldn't automatically mark the release as no longer being a prerelease.

@ncipollo
Copy link
Owner

Ah okay, that makes sense! Thanks for the additional context!

Copy link
Owner

@ncipollo ncipollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new functionality look great! I had a few small nits but after those are addressed I think this will be good to merge!

README.md Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
src/Inputs.ts Show resolved Hide resolved
Copy link
Owner

@ncipollo ncipollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for making those changes!

@ncipollo ncipollo merged commit 7461bfe into ncipollo:main Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants