Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention scope for the GitHub Token #69

Closed
aliasgarlabs opened this issue Jun 30, 2021 · 2 comments
Closed

Mention scope for the GitHub Token #69

aliasgarlabs opened this issue Jun 30, 2021 · 2 comments

Comments

@aliasgarlabs
Copy link

Is your feature request related to a problem? Please describe.
Hi, thanks for this super useful action! Can we please include the scope required for the GitHub Token for the correct execution of this action in the README file? I think this can help people in giving just the right scope to the step :) Thanks!

Describe the solution you'd like
Mention minimum scopes it needs to create a release and upload the artifacts...

Describe alternatives you've considered
Guess the scope it needs and try if it works..

Additional context
None.

@adeptex
Copy link

adeptex commented Aug 22, 2021

Hi there, thanks for your great work on this GH action!

To add info to this issue:

The readme indicates that token: (Required) The GitHub token. Typically this will be ${{ secrets.GITHUB_TOKEN }}.

In my case, not providing a value at all for the token works fine, and publishes the release as github-actions user (in a private repo). I'm not sure that the token value is strictly speaking required, as indicated.

Example config:

    - name: Publish
      uses: ncipollo/release-action@v1
      with:
        commit: master
        tag: atag
        artifacts: "file.txt"
        draft: false
        omitBody: true
        omitBodyDuringUpdate: true
        omitName: true
        omitNameDuringUpdate: true
        omitPrereleaseDuringUpdate: true
        replacesArtifacts: true

Best regards

@ncipollo
Copy link
Owner

ncipollo commented Sep 12, 2021

Updated readme to indicate the action requires repo scope access. I also removed the required indication for that action since it will now correctly default to the workflow's token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants