Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new line separated artifacts syntax #136

Closed
rgl opened this issue Oct 24, 2021 · 3 comments
Closed

Support new line separated artifacts syntax #136

rgl opened this issue Oct 24, 2021 · 3 comments

Comments

@rgl
Copy link

rgl commented Oct 24, 2021

Is your feature request related to a problem? Please describe.

It would pretty interesting to support the same artifact splitting glob syntax as https://github.com/actions/upload-artifact#upload-using-multiple-paths-and-exclusions.

For example, when using upload-artifact/download-artifact/release-action, using new lines to split the globs, we could use the same syntax among those three actions:

jobs:
  amd64:
    steps:
      - name: Upload artifact
        uses: actions/upload-artifact@v2
        with:
          name: amd64
          path: |
            *.iso
            *.img
  release:
    needs:
      - amd64
      - arm64
    steps:
      - name: Download artifacts
        uses: actions/download-artifact@v2
        with:
          path: .
      - name: Release
        uses: ncipollo/release-action@v1
        with:
          artifacts: |
            *.iso
            *.img
          token: ${{ secrets.GITHUB_TOKEN }}

Describe the solution you'd like

Add support for splitting the artifacts by new lines:

      - name: Release
        uses: ncipollo/release-action@v1
        with:
          artifacts: |
            *.iso
            *.img
@ncipollo
Copy link
Owner

You should now be able to use , or a new line to separate artifact globs. Will push a release in a bit.

@rgl
Copy link
Author

rgl commented Oct 25, 2021

Thank You!

@rgl
Copy link
Author

rgl commented Oct 25, 2021

Can the documentation in the README also include this change? Maybe something alike:

artifacts: An optional set of paths representing artifacts to upload to the release. This may be a single path or a comma /new-line delimited list of paths (or globs).

Or even:

artifacts: An optional set of paths representing artifacts to upload to the release. This may be a single path or a comma (or new line) delimited list of paths (or globs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants